code review changes

backend/modules/location/views/state/_form.php

@@ -12,35 +12,31 @@ use yii\widgets\ActiveForm;
 
     <?php $form = ActiveForm::begin(); ?>
 
-    <div id="myTabContent" class="tab-content">
-        <div class="tab-pane fade in active" id="info">
-            <div class="page-header">
-                <h3>Info</h3>
-            </div>
     <div class="row">
         <div class="col-md-6">
 
-                    <?php echo $form->field($model, 'name')->textInput(['maxlength' => true]) ?>
+            <?= $form->field($model, 'name')->textInput(['maxlength' => true]) ?>
 
         </div>
     </div>
     <div class="row">
         <div class="col-md-6">
 
-                    <?php echo $form->field($model, 'slug')->textInput(['maxlength' => true]) ?>
+            <?= $form->field($model, 'slug')->textInput(['maxlength' => true]) ?>
 
         </div>
     </div>
     <div class="row">
         <div class="col-md-3">
+
             <?= $form->field($model, 'status')->dropDownList($model::statuses()) ?>
+
         </div>
     </div>
     <div class="form-group">
+
         <?= Html::submitButton($model->isNewRecord ? Yii::t('backend', 'Create') : Yii::t('backend',
             'Update'), ['class' => $model->isNewRecord ? 'btn btn-success' : 'btn btn-primary']) ?>
-            </div>
-        </div>
 
     </div>
     

backend/modules/location/views/state/index.php

@@ -10,6 +10,7 @@ use yii\grid\GridView;
 $this->title = Yii::t('backend', 'States');
 $this->params['breadcrumbs'][] = $this->title;
 ?>
+
 <div class="state-index">
 
     <h1><?= Html::encode($this->title) ?></h1>
@@ -18,6 +19,7 @@ $this->params['breadcrumbs'][] = $this->title;
     <p>
         <?= Html::a(Yii::t('backend', 'Create State'), ['create'], ['class' => 'btn btn-success']) ?>
     </p>
+    
     <?= GridView::widget([
         'dataProvider' => $dataProvider,
         'filterModel' => $searchModel,
@@ -41,4 +43,5 @@ $this->params['breadcrumbs'][] = $this->title;
             ['class' => 'yii\grid\ActionColumn'],
         ],
     ]); ?>
+    
 </div>

common/models/State.php

@@ -37,7 +37,6 @@ class State extends \yii\db\ActiveRecord
             [
                 'class' => SluggableBehavior::className(),
                 'attribute' => 'name',
-                'immutable' => true
             ],
             [
                 'class' => TimestampBehavior::className(),
@@ -91,6 +90,10 @@ class State extends \yii\db\ActiveRecord
         return new \common\models\query\StateQuery(get_called_class());
     }
 
+    /**
+     * List all status
+     * @return array
+     */
     public static function statuses()
     {
         return [

common/models/query/StateQuery.php

@@ -2,6 +2,8 @@
 
 namespace common\models\query;
 
+use common\models\State;
+
 /**
  * This is the ActiveQuery class for [[\common\models\State]].
  *
@@ -31,4 +33,9 @@ class StateQuery extends \yii\db\ActiveQuery
     {
         return parent::one($db);
     }
+
+    public function active()
+    {
+        return $this->andWhere(['status' => State::STATUS_ACTIVE]);
+    }
 }